-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify configuration methods #551
Conversation
What's the rationale around having it inside |
.get("bootloader") | ||
.map(|bl| package.root().join(bl.as_str().unwrap())); | ||
|
||
// TO BE REMOVED? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remind me again what this is? I don't use cargo-espflash very often 😅.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could set the partition-table
, bootloader
and format
in the package metadata, see https://github.com/esp-rs/espflash/tree/main/cargo-espflash#package-metadata. At the moment, I removed baudrate
and partition-table
properties. IMHO, we can also remove the format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, thanks! Yes lets remove format too.
Tbh, I just followed the suggestion in #469, I can update the path to be |
imo it should probably be in the current directory, but I'll let @jessebraham @bjoernQ and @JurajSadel weigh in too. |
Awesome, let's hear their opinion, I am happy to change it with whatever we decide |
I think I would prefer the current directory |
5377f59
to
6371d0d
Compare
Sorry if I've missed something, why was the Cargo package metadata loading in |
I'd say we can remove the Cargo metadata, as it is now in the config file and its the same for |
That's disappointing, I use it in most of my projects :/ Guess I will switch over, thanks. |
I mean, we can keep it. No hard opinion there, but then we would have multiple ways of defining those configs. |
I updated the local config to live under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checks for config file in:
.cargo/config.toml
as its present in most(or all) our project.Supports the following configurations:
ESPFLASH_PORT
it will be used instead of the config file valueESPFLASH_BAUD
it will be used instead of the config file value[cargo-espflash]: We no longer support setting bootloader, format and partition table in cargo metadata